Fix acceleration/cron recipe: version floor v1.0 β v1.4.0 and stale accelerated size - #598
Merged
Merged
Conversation
β¦ accelerated size refresh_cron does not exist before v1.4.0 β a reader on the declared v1.0 floor cannot follow Step 2 at all. Raise the floor to v1.4.0+, matching the same correction already made to the views recipe (spiceai#538). Step 2's transcript also reports 399.41 MiB for taxi_trips while Step 1 of the same recipe reports 399.38 MiB, which is what the runtime prints today.
lukekim
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Works with v1.0+, but its whole subject β therefresh_cronacceleration parameter added in Step 2 β did not exist until v1.4.0. A reader on v1.0βv1.3 cannot complete the recipe. Same correction already merged for theviewsrecipe in Fix views recipe: correct version floor tov1.4.0+Β #538.399.41 MiBfortaxi_trips; Step 1 of the same recipe reports399.38 MiB, which is what the runtime prints today. A README that contradicts itself about the same dataset is drift regardless of which run is newer.Verified against
spiceai/spiceaiβrefresh_cronfirst appears atv1.4.0:Current definition:
crates/spicepod/src/acceleration/mod.rs:502, consumed atcrates/runtime/src/init/scheduler.rs:219-254.Evidence
Ran the recipe end-to-end on CLI/runtime v2.1.5 (
spice add spiceai/quickstart, addedrefresh_cron: "*/30 * * * * *"tospicepods/spiceai/quickstart/spicepod.yaml,spice run):The cron schedule fires on the 30-second boundary as documented, the
spicepods/spiceai/quickstart/spicepod.yamlpath is correct, and the six-field expression parses (crates/scheduler/src/channel/cron.rs:39-44builds the parser withSeconds::Optional). Row count and size confirmed as 2,964,624 / 399.38 MiB.Load durations in the transcript are left as-is β they vary per run and per network. The
Initializing dataset taxi_tripsline in the same block is corrected separately by #587; this PR deliberately does not touch that line.